Support external-ids when authenticating by STS:AssumeRole #826
Conversation
| assuming roles and profiles. The first two methods are passed in at the | ||
| command line. The third can be configured in the shared credentials file (ie |
There was a problem hiding this comment.
| assuming roles and profiles. The first two methods are passed in at the | |
| command line. The third can be configured in the shared credentials file (ie | |
| assuming roles and profiles. The first two methods are passed in at the | |
| command line. The third can be configured in the shared credentials file (ie |
Is there a reason for the two spaces between sentences?
| @@ -37,6 +37,7 @@ type Credentials struct { | |||
| SecretAccessKey string | |||
| SessionToken string | |||
| AssumeRoleArn string | |||
| ExternalId string | |||
There was a problem hiding this comment.
| ExternalId string | |
| ExternalID string |
I would kindly ask you to write ID in uppercase. I know we are not consistent, but we try to 😄
|
This fixes #817 |
|
@iancward this was implemented on my fork of aws-nuke, which has recently become the active successor to this project. It was implemented via ekristen/aws-nuke#52 If you should run into any issues, please open an issue over there. Please see a copy of the notice from the README about the deprecation of this project. Sven was kind enough to grant me access to help triage and close issues and pull requests that have already been addressed in the actively maintained fork. Some additional information is located in the welcome issue for more information. Caution This repository for aws-nuke is no longer being actively maintained. We recommend users to switch to the actively maintained fork of this project at ekristen/aws-nuke. |
Some users may want to use STS to get temporary credentials to run aws-nuke, and in some cases this may mean providing an External-ID header for the STS:AssumeRole action to get credentials.
(See AWS documentation here )
This pull request adds support for the
--external-idflag in the CLI, passes the flag for client authentication only when provided and includes documentation for its use in README.I've been using this code on an internal fork for a few months with no problems.